Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6/n] Macro optimization #525

Closed
wants to merge 10 commits into from
Closed

Conversation

Dirbaio
Copy link
Contributor

@Dirbaio Dirbaio commented Jun 30, 2021

Part of #492. Depends on #524 #508

I've been experimenting with optimizing the macro codegen to "batch" known-size values together before writing. Doesn't get the code size savings I expect on the QEMU tests, so WIP for now. Maybe requires more work, maybe it's not worth in the end.

@Urhengulas Urhengulas added the pr waits on: author Pull Request requires changes from the author label Jul 7, 2021
@jonas-schievink jonas-schievink mentioned this pull request Aug 5, 2021
@Urhengulas
Copy link
Member

Hi @Dirbaio, Are you still planning to work on this PR? 😁

@Dirbaio
Copy link
Contributor Author

Dirbaio commented Sep 8, 2021

It got sent to conflict hell by #531, so it requires a rewrite. I still want to do it, but don't have much free time so I don't know when.

The optimizations don't break wire format, so it shouldn't be blocking for the 0.3 release though. It can be added in a 0.3.x release later.

@Urhengulas
Copy link
Member

It got sent to conflict hell by #531, so it requires a rewrite. I still want to do it, but don't have much free time so I don't know when.

The optimizations don't break wire format, so it shouldn't be blocking for the 0.3 release though. It can be added in a 0.3.x release later.

I see. Then we just keep it and you can come back to it as soon you have time and energy :)
Thanks!

@Urhengulas
Copy link
Member

I will close this PR for now. If you want to pick it up again just re-open it, or open a new one 😄

@Urhengulas Urhengulas closed this Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr waits on: author Pull Request requires changes from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants