-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6/n] Macro optimization #525
Conversation
Hi @Dirbaio, Are you still planning to work on this PR? 😁 |
It got sent to conflict hell by #531, so it requires a rewrite. I still want to do it, but don't have much free time so I don't know when. The optimizations don't break wire format, so it shouldn't be blocking for the 0.3 release though. It can be added in a 0.3.x release later. |
I see. Then we just keep it and you can come back to it as soon you have time and energy :) |
I will close this PR for now. If you want to pick it up again just re-open it, or open a new one 😄 |
Part of #492. Depends on #524 #508
I've been experimenting with optimizing the macro codegen to "batch" known-size values together before writing. Doesn't get the code size savings I expect on the QEMU tests, so WIP for now. Maybe requires more work, maybe it's not worth in the end.