GHA: remove ci-failure #326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors' semantics have changed: skipped checks are now considered failures the result is that when all build jobs pass the ci-failure reports a "ci" check as skipped (expected behavior) but that is now considered a failure by bors removing the ci-failure conditional should fix the issue if any build job fails then ci-success will report "ci" as skipped, which bors will consider as a failure
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 4, 2021
326: GHA: remove ci-failure r=japaric a=japaric bors' semantics have changed: skipped checks are now considered failures the result is that when all build jobs pass the ci-failure reports a "ci" check as skipped (expected behavior) but that is now considered a failure by bors removing the ci-failure conditional should fix the issue if any build job fails then ci-success will report "ci" as skipped, which bors will consider as a failure Co-authored-by: Jorge Aparicio <jorge.aparicio@ferrous-systems.com>
|
right, this needs to land together with PR #325 |
|
Build failed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bors' semantics have changed: skipped checks are now considered failures
the result is that when all build jobs pass the ci-failure reports a "ci" check as skipped
(expected behavior) but that is now considered a failure by bors
removing the ci-failure conditional should fix the issue
if any build job fails then ci-success will report "ci" as skipped, which bors will consider as a
failure