Skip to content

Commit

Permalink
GHA: remove ci-failure
Browse files Browse the repository at this point in the history
bors' semantics have changed: skipped checks are now considered failures
the result is that when all build jobs pass the ci-failure reports a "ci" check as skipped
(expected behavior) but that is now considered a failure by bors

removing the ci-failure conditional should fix the issue
if any build job fails then ci-success will report "ci" as skipped, which bors will consider as a
failure
  • Loading branch information
japaric committed Jan 4, 2021
1 parent c4461eb commit 7ebed28
Showing 1 changed file with 0 additions and 13 deletions.
13 changes: 0 additions & 13 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -141,16 +141,3 @@ jobs:
steps:
- name: CI succeeded
run: exit 0

ci-failure:
name: ci
if: ${{ !success() }}
needs:
- test
- no-std
- mdbook
- qemu
runs-on: ubuntu-20.04
steps:
- name: CI failed
run: exit 1

0 comments on commit 7ebed28

Please sign in to comment.