Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Odnoklassniki, Slack, Vimeo, Yahoo and Yandex providers #47

Merged
merged 1 commit into from
Jan 10, 2017
Merged

added Odnoklassniki, Slack, Vimeo, Yahoo and Yandex providers #47

merged 1 commit into from
Jan 10, 2017

Conversation

luchianenco
Copy link
Contributor

my opinion is that config.yml code becomes too long for readme file. It would be great to create a separate file with all configuration options

@weaverryan weaverryan merged commit 4b4b6e7 into knpuniversity:master Jan 10, 2017
@weaverryan
Copy link
Member

Wow, this AMAZING! You've basically doubled our providers in 2 days - really cool :). I'll tag a new release right now (I don't usually like to wait - I want people to be able to use the new stuff).

Btw, about the README, 2 things:

  1. You're right that the config section is long... but I don't think it's a problem (it's at the bottom). Also, it's nice for people to be able to just search (via their browser - e.g. cmd+f) for something and have the README all on one page.

  2. I should have told you earlier, but I didn't know you were going to send so many providers! But, there is an automated script to build the README config from the configuration files - bin/update_readme. You can run that to automatically update the README.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants