Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop reference to Symfony 3 #433

Merged
merged 2 commits into from
Feb 20, 2024
Merged

drop reference to Symfony 3 #433

merged 2 commits into from
Feb 20, 2024

Conversation

tacman
Copy link
Contributor

@tacman tacman commented Feb 20, 2024

Since this bundle requires at least Symfony 4, no reason to keep the documentation for Symfony 3.

Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tacman!

README.md Outdated
Comment on lines 191 to 192
// on Symfony 3.3 or lower, $clientRegistry = $this->get('knpu.oauth2.registry');

// will redirect to Facebook!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the extra line right before // will redirect.....

@jrushlow jrushlow added Status: Needs Work Additional work is needed Minor Minor Enhancement labels Feb 20, 2024
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tacman!

@jrushlow jrushlow merged commit 6dbf6b6 into knpuniversity:master Feb 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Minor Enhancement Status: Needs Work Additional work is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants