Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VKontakte provider added #42

Merged
merged 2 commits into from
Jan 9, 2017

Conversation

fatihkahveci
Copy link
Contributor

for issue #7 VKontakte provider added.

@okwinza
Copy link
Contributor

okwinza commented Nov 10, 2016

That lib you're trying to integrate is still not compatible with thephpleague/oauth2-client 2.0 as it requires ^1.4 in composer.json

See #10

@fatihkahveci
Copy link
Contributor Author

@okwinza ups :/ . I can't find compatible with thephpleague/oauth2-client any VK provider. I guesse i will tackle that asap.

@okwinza okwinza mentioned this pull request Jan 8, 2017
@weaverryan
Copy link
Member

I just re-checked things because #46 was opened - it looks like the library has been updated since June last year: j4k/oauth2-vkontakte@3691945

So, I think we can merge this now.

@fatihkahveci
Copy link
Contributor Author

@weaverryan I just fix conflict we can merge now 😃

@okwinza
Copy link
Contributor

okwinza commented Jan 9, 2017

@weaverryan wow how did i miss that. In this case we definitely can merge this. 👍

@weaverryan weaverryan merged commit b117f4d into knpuniversity:master Jan 9, 2017
weaverryan added a commit that referenced this pull request Jan 9, 2017
@weaverryan
Copy link
Member

Very fast - thank you @fatihkahveci! Already tagged 1.7.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants