feat: add Webflow provider #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi folks at @knpuniversity 👋 Is there anything blocking this PR from being merged in its current state? |
|
|
||
| public function getProviderClass(array $config) | ||
| { | ||
| return 'Koalati\OAuth2\Client\Provider\Webflow'; |
There was a problem hiding this comment.
We can use return Webflow::class here too instead of hardcoding this as a string.. but don't forget to use the namespace too :)
weaverryan
reviewed
Mar 17, 2023
|
Thanks to the both of you - and no worries on the delay, you folks do more than enough! I just changed the hardcoded string; the PHP 8.1 and 8.2 tests "failed" but the errors in these seemed to be deprecations in other parts of the codebase. Let me know if there's anything else you need me to do :) Cheers! |
bocharsky-bw
approved these changes
Mar 20, 2023
bocharsky-bw
added a commit
that referenced
this pull request
Mar 20, 2023
In order to fix the deprecation message in #395
|
Failed tests are really unrelated to this PR and fixed in #397 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an implmentation for the new
koalati/oauth2-webflowOAuth 2.0 provider for Webflow.