Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for OAuth 2.0 PKCE #386

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

MLukman
Copy link
Contributor

@MLukman MLukman commented Jan 28, 2023

Added OAuth2PKCEClient that supports OAuth 2.0 providers with PKCE extension (https://oauth.net/2/pkce/)

@MLukman
Copy link
Contributor Author

MLukman commented Jan 30, 2023

Referring to the failing Bundle CI / Tests 7.2, which Symfony versions do we still need to support? RequestStack::getSession() has been existing since 5.3 ..

@weaverryan
Copy link
Member

Hi!

Referring to the failing Bundle CI / Tests 7.2, which Symfony versions do we still need to support? RequestStack::getSession() has been existing since 5.3 ..

We could bump the minimum-supported version of Symfony in this bundle to 5.4. Then we can just call the session properly. Does that help?

Cheers!

@MLukman
Copy link
Contributor Author

MLukman commented Jan 30, 2023

Dear maintainers, please assist on error PHP-CS-Fixer below which is not related to the code:

PHP needs to be a minimum version of PHP 7.4.0 and maximum version of PHP 8.1.*.
Current PHP version: 8.2.1.
To ignore this requirement please set `PHP_CS_FIXER_IGNORE_ENV`.
If you use PHP version higher than supported, you may experience code modified in a wrong way.
Please report such cases at https://github.com/PHP-CS-Fixer/PHP-CS-Fixer .
Error: Process completed with exit code 1.

@MLukman
Copy link
Contributor Author

MLukman commented Jan 31, 2023

Hi!

Referring to the failing Bundle CI / Tests 7.2, which Symfony versions do we still need to support? RequestStack::getSession() has been existing since 5.3 ..

We could bump the minimum-supported version of Symfony in this bundle to 5.4. Then we can just call the session properly. Does that help?

Cheers!

Thanks for your kind reply but I've modified the class a bit to fetch the session from the Request object fetched from RequestStack::getCurrentRequest() just like OAuth2Client does. So please maintain the current version support setting since we don't want to break other people's applications who use this bundle. There are still many out there still running Symfony 4.4 (cough prestashop cough)

@bocharsky-bw
Copy link
Member

Dear maintainers, please assist on error PHP-CS-Fixer below which is not related to the code

PHP CS Fixer does not support the latest PHP 8.2 version yet. I created a PR to make it green, see #387

@weaverryan
Copy link
Member

Fair enough - thank you @MLukman!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants