Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add provider for Spotify #229

Merged
merged 1 commit into from
Mar 19, 2020
Merged

Add provider for Spotify #229

merged 1 commit into from
Mar 19, 2020

Conversation

ker0x
Copy link
Contributor

@ker0x ker0x commented Mar 3, 2020

No description provided.

bocharsky-bw
bocharsky-bw approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution!

weaverryan
weaverryan reviewed Mar 3, 2020
View reviewed changes
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR - I just saw one small change needed!

src/DependencyInjection/Providers/SpotifyProviderConfigurator.php Outdated Show resolved Hide resolved
@weaverryan
Add provider for Spotify
ca168d6 
Co-Authored-By: Ryan Weaver <weaverryan+github@gmail.com>
@ker0x
Copy link
Contributor Author

ker0x commented Mar 4, 2020

Hello @weaverryan,

Everything should be good now ;)!

@weaverryan weaverryan merged commit fd892fe into knpuniversity:master Mar 19, 2020
@weaverryan
Copy link
Member

Thanks @ker0x!

@ker0x ker0x deleted the feature/spotify-provider branch April 7, 2020 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverryan weaverryan weaverryan left review comments

@bocharsky-bw bocharsky-bw bocharsky-bw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ker0x @weaverryan @bocharsky-bw