Oauth apple support #221
Oauth apple support #221
Conversation
| public function getProviderOptions(array $configuration) | ||
| { | ||
| return [ | ||
| 'clientId' => $configuration['client_id'], |
There was a problem hiding this comment.
Ah, wait, client_secret is missing here :)
There was a problem hiding this comment.
apple does not have a client_secret, they use the key_file instead
There was a problem hiding this comment.
In this case, we should remove client_secret from the docs I think
| public function getProviderOptions(array $configuration) | ||
| { | ||
| return [ | ||
| 'clientId' => $configuration['client_id'], |
There was a problem hiding this comment.
In this case, we should remove client_secret from the docs I think
| type: apple | ||
| # add and configure client_id and client_secret in parameters.yml | ||
| client_id: '%env(OAUTH_APPLE_CLIENT_ID)%' | ||
| client_secret: '%env(OAUTH_APPLE_CLIENT_SECRET)%' |
There was a problem hiding this comment.
No client_secret? We need to find a way to remove this line then to avoid confusion. I wonder if we have any other clients in this bundle that don't have client_secret as well, how do we remove this field from docs?
There was a problem hiding this comment.
at beginning i removed it and added the needed custom params, but it causes the build to fail ><
i've also tried to add a comment on the line, same, build fails..
i dunno :/
|
I'll fix up the README - my weird script for it probably needs to be tweaked :) |
|
Tagged in 1.32.0. Thanks! |
Adds support for oauth-apple