feat(kno-5440): add slack functions #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylemcd
approved these changes
Mar 5, 2024
Comment on lines
+97
to
+101
| typeof value === "object" && | ||
| value !== null && | ||
| !(value instanceof Date) && | ||
| !(value instanceof Array) | ||
| ) { |
There was a problem hiding this comment.
I'm sure this is needed just curious what this thorough of a check is doing?
There was a problem hiding this comment.
oh this is just making sure this is only processing plain objects ({}) - is there a better way to do that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds slack functions and also extends our url builder to work with nested objects, which we need for one of the functions in here.