fix: handle single error responses #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjbell
reviewed
Jan 24, 2024
| const { errors } = data; | ||
| const errors = Array.isArray(data.errors) | ||
| ? data.errors | ||
| : [data.errors]; |
There was a problem hiding this comment.
If errors is null or undefined, then won't this end up as [null]?
There was a problem hiding this comment.
Good call, added an extra check if errors is not defined
connorlindsey
deleted the
connor-kno-5071-node-sdk-errors-not-iterable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The API typically returns an array of error messages but in some cases, returns a single error. This update checks if errors is an array or single instance. If it's a single error, it wraps it in an array so that formatting the error message works correctly in
UnprocessableEntityExceptionResolves #47