replace cargo.rs using cargo crate #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current racer's crafty crate search has many problems(e.g. nanomsg crate(see comments in issue 551)). So I replaced it with cargo crate. I also had to rewrote some parts of test, because cargo needs absolute pass to construct workspace. In addition, I removed all sync!() in test code, because it's useless. File IO is thread safe because we're using thread name as tempdir name, and, I don't think test code should be 100% safe. Now test is much faster. Except sometimes I feel it's a bit slow, it works well.
12 tasks
This was referenced May 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current racer's crafty crate search has many problems(e.g. nanomsg crate(see comments in 551)).
So I replaced it with cargo crate.
I also had to rewrote some parts of test, because cargo needs absolute pass to construct workspace. In addition, I removed all sync!() in test code, because it's useless. File IO is thread safe because we're using thread name as tempdir name, and, I don't think test code should be 100% safe. Now test is much faster.
It works well, but sometimes I feel completion is quite slow(e.g. when I type
libin fileres.rs, my emacs froze about 3~4 seconds).So it's next problem to tackle.