Seeds now support multiple seed directories, with a sorting option. #3357
Conversation
candyapplecorn
force-pushed
the
feature/add-multiple-seed-directory-support
branch
from
70869c7
to
2b3adda
Compare
candyapplecorn
force-pushed
the
feature/add-multiple-seed-directory-support
branch
from
2b3adda
to
b18f12c
Compare
|
Closed because actual manual testing revealed this code to not work. Thought the jake cli tests would take care of that for me but nope, there's more to it. |
| @@ -15,6 +15,75 @@ const KNEX = path.normalize(__dirname + '/../../../bin/cli.js'); | |||
| const taskList = []; | |||
| /* * * TESTS * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | |||
|
|
|||
| test( | |||
There was a problem hiding this comment.
I would say that for new tests cli-testlab tests would be preferable (and easier to write) than using jake directly. See test/cli/migrate-make.spec.js for an example.
Also async/await is preferred over using promise chains.
There was a problem hiding this comment.
@kibertoad Thanks for the tips. I will use cli-testlab instead. Also, yeah, I definitely didn't want to be using promise chains and Bluebird. I just figured the rest of the codebase was using it, so I should too. So, cool! async await valhalla awaits me
| @@ -0,0 +1 @@ | |||
| exports.seed = (knex, Promise) => {}; | |||
There was a problem hiding this comment.
Promise is not passed to seeds anymore, I think
|
Released in 0.21.3 |
This pull request enables Knex's seed feature to:
Link to documentation branch's pull request: knex/documentation#220