Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.13 release in serving failed due to auto tls test failure #1778

Closed
chaodaiG opened this issue Mar 3, 2020 · 7 comments
Closed

0.13 release in serving failed due to auto tls test failure #1778

chaodaiG opened this issue Mar 3, 2020 · 7 comments
Labels
bug Something isn't working lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@chaodaiG
Copy link
Contributor

chaodaiG commented Mar 3, 2020

Knative 0.13 release failed due to auto tls test failure, and the root cause is that auto tls test relies on service account for talking to dns server, and it doesn't exist in auto release job. See example failure: https://prow.knative.dev/view/gcs/knative-prow/logs/ci-knative-serving-auto-release/1234880014055378945

The release was done by a hacky way to unblock releasing, by manually mounting the service account to the job, and kicked off manually here: https://prow.knative.dev/view/gcs/knative-prow/logs/ci-knative-serving-auto-release/1234940914212802561

The fix above was a one-time thing, if there is any new release come up it'll fail the same way, so we need a long term fix.

[Note] We don't want 0.13.1 being released just because of this fix, as the binaries being released will be identical to 0.13.0

@chaodaiG
Copy link
Contributor Author

chaodaiG commented Mar 3, 2020

/kind bug

@knative-prow-robot
Copy link
Collaborator

@chaodaiG: The label(s) kind/bug cannot be applied, because the repository doesn't have them

In response to this:

/kind bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chaodaiG
Copy link
Contributor Author

chaodaiG commented Mar 3, 2020

/bug
/assign @nbarthwal

@knative-housekeeping-robot

Issues go stale after 90 days of inactivity.
Mark the issue as fresh by adding the comment /remove-lifecycle stale.
Stale issues rot after an additional 30 days of inactivity and eventually close.
If this issue is safe to close now please do so by adding the comment /close.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/lifecycle stale

@knative-prow-robot knative-prow-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 2, 2020
@chizhg
Copy link
Member

chizhg commented Jul 17, 2020

/reopen

@knative-prow-robot
Copy link
Collaborator

@chizhg: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 17, 2020
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen.Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

5 participants