Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dot-release is running the ./hack/release.sh in master branch #1262

Closed
chizhg opened this issue Aug 13, 2019 · 5 comments · Fixed by #1802
Closed

dot-release is running the ./hack/release.sh in master branch #1262

chizhg opened this issue Aug 13, 2019 · 5 comments · Fixed by #1802

Comments

@chizhg
Copy link
Member

chizhg commented Aug 13, 2019

eventing-contrib repo is doing a dot-release but the job ended up with an error.

From the job logs https://prow.knative.dev/log?job=ci-knative-eventing-contrib-dot-release&id=1161353664162435072, we can see the error is 2019/08/13 19:14:03 Error enumerating files: lstat github/config/: no such file or directory. However, github/config/ is a path written in the ./hack/release.sh of master branch but not 0.8 branch.

Our dot-release job should use ./hack/release.sh in branch 0.8, instead of master.

/cc @adrcunha

FYI @chaodaiG since he found the reason of this bug.

@adrcunha adrcunha self-assigned this Aug 13, 2019
@adrcunha
Copy link
Contributor

The way the release script currently works it runs indeed from the master branch.

The workaround is to manually create a dot-release job, and update it to use the branch before starting it. This will be addressed in test-infra 2.0.

@adrcunha
Copy link
Contributor

@knative-prow-robot
Copy link
Collaborator

@adrcunha: Closing this issue.

In response to this:

New release published successfully:

https://prow.knative.dev/log?job=ci-knative-eventing-contrib-dot-release&id=1161389776184545280

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chizhg
Copy link
Member Author

chizhg commented Feb 15, 2020

/unassign @adrcunha

As test-infra 2.0 was not launched as planned, this issue still needs to be addressed.

/reopen

@knative-prow-robot
Copy link
Collaborator

@chizhg: Reopened this issue.

In response to this:

/unassign @adrcunha

As test-infra 2.0 was not launched as planned, this issue still needs to be addressed.

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants