Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement krshaped for networking #7879

Merged
merged 4 commits into from
May 8, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented May 7, 2020

Issue #1226

Proposed Changes

  • Implements the KRShaped interface for the v1alpha1 networking resources
    • Will allow common logic in the generated reconciler

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 7, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 7, 2020
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whaught: 0 warnings.

In response to this:

Issue #1226

Proposed Changes

  • Implements the KRShaped interface for the v1alpha1 networking resources
    • Will allow common logic in the generated reconciler

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Co-authored-by: Matt Moore <mattmoor@vmware.com>
@knative-test-reporter-robot

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-unit-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-serving-unit-tests:

pkg/apis/networking/v1alpha1.[setup failed]

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/networking/v1alpha1/certificate_types.go Do not exist 100.0%
pkg/apis/networking/v1alpha1/ingress_types.go Do not exist 100.0%
pkg/apis/networking/v1alpha1/serverlessservice_types.go Do not exist 100.0%

@whaught
Copy link
Contributor Author

whaught commented May 7, 2020

/assign @nak3

@whaught
Copy link
Contributor Author

whaught commented May 7, 2020

/retest

@nak3
Copy link
Contributor

nak3 commented May 8, 2020

Issue #1226

I'm sorry if I misunderstood, but is this PR really related to #1226 ?

But anyway, the change looks good to me.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2020
@ZhiminXiang
Copy link

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: whaught, ZhiminXiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2020
@knative-prow-robot knative-prow-robot merged commit 25306e4 into knative:master May 8, 2020
@knative-prow-robot
Copy link
Contributor

@whaught: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-serving-integration-tests 673544b link /test pull-knative-serving-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@whaught whaught deleted the networking-shape branch May 18, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/networking cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants