Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prometheus deployment & collect common metrics #189

Merged
merged 1 commit into from
Feb 17, 2018
Merged

Add Prometheus deployment & collect common metrics #189

merged 1 commit into from
Feb 17, 2018

Conversation

mdemirhan
Copy link
Contributor

  • Added configs to deploy Prometheus, Prometheus Operator & Grafana with out of the box defaults that collect k8s, istio & node metrics.
  • Added a sample app to demonstrate adding app specific metrics and how they can be collected.

…ith out of the box defaults that collect k8s, istio & node metrics.

- Added a sample app to demonstrate adding app specific metrics and how they can be collected.
Copy link
Contributor

@josephburnett josephburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Looks like this wires in custom metrics. But not Istio metrics yet, right?

@mdemirhan mdemirhan merged commit 8976fb3 into knative:master Feb 17, 2018
@mdemirhan mdemirhan deleted the mdemirhan/prometheus branch February 17, 2018 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants