Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for hostipc, hostpid and hostnetwork #15414

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Jul 25, 2024

Fixes #12830

Proposed Changes

Release Note

Allow hostPID, hostNetwork and HostIPC to be set for a Knative Service (feature flags: kubernetes.podspec-hostpid, kubernetes.podspec-hostnetwrok, kubernetes.podspec-hostipc). All features are disabled by default. 

@knative-prow knative-prow bot requested review from dprotaso and izabelacg July 25, 2024 11:31
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 25, 2024
@skonto skonto requested a review from ReToCode July 25, 2024 11:31
@skonto skonto changed the title Add support for hostipc, hostpid and hostnetwork [wip] Add support for hostipc, hostpid and hostnetwork Jul 25, 2024
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.57%. Comparing base (7d318cd) to head (e9dddaa).
Report is 18 commits behind head on main.

Files Patch % Lines
pkg/apis/serving/fieldmask.go 0.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15414      +/-   ##
==========================================
- Coverage   84.60%   84.57%   -0.04%     
==========================================
  Files         219      219              
  Lines       13587    13597      +10     
==========================================
+ Hits        11495    11499       +4     
- Misses       1725     1728       +3     
- Partials      367      370       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link
Contributor Author

skonto commented Jul 25, 2024

TestSubrouteLocalSTS/shortest failed with Contour. cc @dprotaso

@skonto skonto changed the title [wip] Add support for hostipc, hostpid and hostnetwork Add support for hostipc, hostpid and hostnetwork Jul 25, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 25, 2024
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold for @dprotaso

@knative-prow knative-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jul 26, 2024
@skonto
Copy link
Contributor Author

skonto commented Jul 30, 2024

@dprotaso gentle ping.

@dprotaso
Copy link
Member

dprotaso commented Aug 1, 2024

/lgtm

@dprotaso
Copy link
Member

dprotaso commented Aug 1, 2024

/approve

Copy link

knative-prow bot commented Aug 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2024
@skonto
Copy link
Contributor Author

skonto commented Aug 1, 2024

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2024
@knative-prow knative-prow bot merged commit 2b86c14 into knative:main Aug 1, 2024
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Knative options to support for shared GPU resources with PSP
4 participants