Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automated] Update net-gateway-api nightly #14789

Merged

Conversation

knative-automation
Copy link
Contributor

@knative-automation knative-automation commented Jan 15, 2024

/assign @knative/serving-writers
/cc @knative/serving-writers

Produced via:

for x in net-gateway-api.yaml istio-gateway.yaml gateway-api.yaml; do
  curl https://storage.googleapis.com/knative-nightly/net-gateway-api/latest/$x > ${GITHUB_WORKSPACE}/./third_party/gateway-api-latest/$x
done

Details:

bumping knative.dev/net-gateway-api 03b7baa...e8f620a:
  > e8f620a upgrade to latest dependencies (# 603)
  > b5c0e3e Update community files (# 602)

@knative-prow knative-prow bot requested a review from a team January 15, 2024 11:05
@knative-prow knative-prow bot added area/networking size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 15, 2024
@ReToCode
Copy link
Member

/test gateway-api-latest

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2024
Copy link

knative-prow bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-automation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2024
@dprotaso
Copy link
Member

cc @KauzClay this might be related to the appProtocol changes

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (d96dabb) 86.05% compared to head (cbe0b75) 85.94%.
Report is 4 commits behind head on main.

Files Patch % Lines
pkg/queue/sharedmain/handlers.go 0.00% 12 Missing ⚠️
pkg/activator/handler/context.go 60.00% 3 Missing and 1 partial ⚠️
pkg/activator/handler/handler.go 66.66% 2 Missing and 1 partial ⚠️
cmd/activator/main.go 0.00% 2 Missing ⚠️
pkg/http/handler/timeout.go 0.00% 2 Missing ⚠️
pkg/http/response_recorder.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14789      +/-   ##
==========================================
- Coverage   86.05%   85.94%   -0.11%     
==========================================
  Files         197      197              
  Lines       14950    14991      +41     
==========================================
+ Hits        12865    12884      +19     
- Misses       1774     1794      +20     
- Partials      311      313       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member

/retest

@KauzClay
Copy link
Contributor

KauzClay commented Jan 16, 2024

so, I reverted my changes (e5602d7), and tried just installing serving+net-gatewayapi (istio as ingress), and I still can’t get a ksvc to come up.

The ingress is configured in config-network, the local gateways are there, the gateway-api CRDs are installed, and the httproutes even get created. But the probes are failing with 404s.

{"severity":"ERROR","timestamp":"2024-01-16T20:51:52.935678909Z","logger":"net-gateway-api-controller","caller":"status/status.go:405","message":"Probing of http://test.default.svc.cluster.local/ failed, IP: 10.80.4.11:8081, ready: false, error: unexpected status code: want 200, got 404 (depth: 0)","commit":"e8f620a","knative.dev/controller":"knative.dev.net-gateway-api.pkg.reconciler.ingress.Reconciler","knative.dev/kind":"networking.internal.knative.dev.Ingress","knative.dev/traceid":"783da17b-f5a9-4121-8b9f-2af6ad17fe2f","knative.dev/key":"default/test","stacktrace":"knative.dev/networking/pkg/status.(*Prober).processWorkItem\n\tknative.dev/networking@v0.0.0-20240115131931-22485740979e/pkg/status/status.go:405\nknative.dev/networking/pkg/status.(*Prober).Start.func1\n\tknative.dev/networking@v0.0.0-20240115131931-22485740979e/pkg/status/status.go:290"}
{"severity":"ERROR","timestamp":"2024-01-16T20:51:52.935722317Z","logger":"net-gateway-api-controller","caller":"status/status.go:405","message":"Probing of http://test.default/ failed, IP: 10.80.4.11:8081, ready: false, error: unexpected status code: want 200, got 404 (depth: 0)","commit":"e8f620a","knative.dev/controller":"knative.dev.net-gateway-api.pkg.reconciler.ingress.Reconciler","knative.dev/kind":"networking.internal.knative.dev.Ingress","knative.dev/traceid":"783da17b-f5a9-4121-8b9f-2af6ad17fe2f","knative.dev/key":"default/test","stacktrace":"knative.dev/networking/pkg/status.(*Prober).processWorkItem\n\tknative.dev/networking@v0.0.0-20240115131931-22485740979e/pkg/status/status.go:405\nknative.dev/networking/pkg/status.(*Prober).Start.func1\n\tknative.dev/networking@v0.0.0-20240115131931-22485740979e/pkg/status/status.go:290"}
{"severity":"ERROR","timestamp":"2024-01-16T20:51:52.935830292Z","logger":"net-gateway-api-controller","caller":"status/status.go:405","message":"Probing of http://test.default.svc/ failed, IP: 10.80.4.11:8081, ready: false, error: unexpected status code: want 200, got 404 (depth: 0)","commit":"e8f620a","knative.dev/controller":"knative.dev.net-gateway-api.pkg.reconciler.ingress.Reconciler","knative.dev/kind":"networking.internal.knative.dev.Ingress","knative.dev/traceid":"783da17b-f5a9-4121-8b9f-2af6ad17fe2f","knative.dev/key":"default/test","stacktrace":"knative.dev/networking/pkg/status.(*Prober).processWorkItem\n\tknative.dev/networking@v0.0.0-20240115131931-22485740979e/pkg/status/status.go:405\nknative.dev/networking/pkg/status.(*Prober).Start.func1\n\tknative.dev/networking@v0.0.0-20240115131931-22485740979e/pkg/status/status.go:290"}

I also created another ksvc with the istio ingress class annotation, and that comes up fine.

❯ k get ksvc
NAME    URL                                   LATESTCREATED   LATESTREADY   READY     REASON
istio   http://istio.default.kauz.tanzu.biz   istio-00001     istio-00001   True
test    http://test.default.kauz.tanzu.biz    test-00001      test-00001    Unknown   Uninitialized

I still feel like I could be doing something wrong though, does it sound like I’m missing anything?

EDIT: my istio install was busted

bumping knative.dev/net-gateway-api 03b7baa...e8f620a:
  > e8f620a upgrade to latest dependencies (# 603)
  > b5c0e3e Update community files (# 602)

Signed-off-by: Knative Automation <automation@knative.team>
@dprotaso
Copy link
Member

/retest
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2024
@knative-prow knative-prow bot merged commit 9a867e1 into knative:main Jan 17, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/networking lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants