-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Automated] Update net-gateway-api nightly #14789
[Automated] Update net-gateway-api nightly #14789
Conversation
c95da9e
to
32bef71
Compare
/test gateway-api-latest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, knative-automation The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cc @KauzClay this might be related to the |
32bef71
to
3c169b2
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #14789 +/- ##
==========================================
- Coverage 86.05% 85.94% -0.11%
==========================================
Files 197 197
Lines 14950 14991 +41
==========================================
+ Hits 12865 12884 +19
- Misses 1774 1794 +20
- Partials 311 313 +2 ☔ View full report in Codecov by Sentry. |
/retest |
so, I reverted my changes (e5602d7), and tried just installing serving+net-gatewayapi (istio as ingress), and I still can’t get a ksvc to come up. The ingress is configured in config-network, the local gateways are there, the gateway-api CRDs are installed, and the httproutes even get created. But the probes are failing with 404s.
I also created another ksvc with the istio ingress class annotation, and that comes up fine.
I still feel like I could be doing something wrong though, does it sound like I’m missing anything? EDIT: my istio install was busted |
bumping knative.dev/net-gateway-api 03b7baa...e8f620a: > e8f620a upgrade to latest dependencies (# 603) > b5c0e3e Update community files (# 602) Signed-off-by: Knative Automation <automation@knative.team>
3c169b2
to
cbe0b75
Compare
/retest |
/assign @knative/serving-writers
/cc @knative/serving-writers
Produced via:
Details: