-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename auto-tls to external-domain-tls #14482
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14482 +/- ##
=======================================
Coverage 86.04% 86.04%
=======================================
Files 196 196
Lines 14880 14887 +7
=======================================
+ Hits 12803 12810 +7
Misses 1764 1764
Partials 313 313
☔ View full report in Codecov by Sentry. |
/test https |
2 similar comments
/test https |
/test https |
/test https |
@ReToCode: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Not sure if the https errors are really related to the changes here. Tests seem not to work at all (https://testgrid.k8s.io/r/knative-own-testgrid/serving#https). |
You are correct. HTTPS test is not stable now #14435 |
/lgtm I think I don't have a power to approve though. |
@dprotaso would you mind taking a look ^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some minor comments that can be done in a follow up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make a follow up issue so we don't forget to remove this file after the infra changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename filename in follow up
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, nak3, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test https_serving_main |
Fixes #14369
Proposed Changes
auto-tls
toexternal-domain-tls
external-domain-tls
tests locallyRelease Note
Is covered in #14472
Followup work