Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add Kubernetes 1.22 to CI (Debug status subresource admission errors) #11805

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/kind-e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,10 @@ jobs:
fail-fast: false # Keep running if one leg fails.
matrix:
k8s-version:
- v1.19.11
- v1.20.7
- v1.21.1
# - v1.19.11
# - v1.20.7
# - v1.21.1
- v1.22.0

test-suite:
- ./test/conformance/runtime
Expand All @@ -47,6 +48,11 @@ jobs:
kind-image-sha: sha256:69860bda5563ac81e3c0057d654b5253219618a22ec3a346306239bba8cfa1a6
kingress: kourier
cluster-suffix: c${{ github.run_id }}.local
- k8s-version: v1.22.0
kind-version: v0.11.1
kind-image-sha: sha256:f97edf7f7ed53c57762b24f90a34fad101386c5bd4d93baeb45449557148c717
kingress: kourier
cluster-suffix: c${{ github.run_id }}.local

# The tests in api/v1alpha1 require the --enable-alpha flag to be set,
# and alpha components to be deployed.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ func (ac *reconciler) mutate(ctx context.Context, req *admissionv1.AdmissionRequ
newDecoder.DisallowUnknownFields()
}
if err := newDecoder.Decode(&newObj); err != nil {
return nil, fmt.Errorf("cannot decode incoming new object: %w", err)
return nil, fmt.Errorf("cannot decode incoming new object: %w\noriginal:\n%#v", err, string(newBytes))
}
}
if len(oldBytes) != 0 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ func (ac *reconciler) decodeRequestAndPrepareContext(
newDecoder.DisallowUnknownFields()
}
if err := newDecoder.Decode(&newObj); err != nil {
return ctx, nil, fmt.Errorf("cannot decode incoming new object: %w", err)
return ctx, nil, fmt.Errorf("cannot decode incoming new object: %w\noriginal:\n%#v", err, newObj)
}
}

Expand Down