A deployment with all unschedulable pods should show up in revision status

[mdemirhan]

/area API

If there are no resources remaining in a cluster to deploy a pod and when we try to scale up from zero, or when a user deploys a new revision, we should bubble up the information about the lack of capacity in revision status and make it easier for users to understand why their revisions might not be starting up correctly.

[mattmoor]

/assign @jonjohnsonjr

Jon, please let me know if this isn't within the scope you are tracking.

[jonjohnsonjr]

This may have been fixed by #4191?

[jonjohnsonjr]

Confirmed this was fixed by tainting all my nodes:

$ for node in $(kubectl get nodes -oname); do kubectl taint nodes $node key=value:NoSchedule; done

When trying to scale up a revision, I see this in the ksvc status:

  - lastTransitionTime: "2019-08-14T21:24:08Z"
    message: 'Revision "counter-gzhj8" failed with message: 0/2 nodes are available:
      2 node(s) had taints that the pod didn''t tolerate..'
    reason: RevisionFailed
    status: "False"
    type: Ready

🎉

To untaint the nodes:

$ for node in $(kubectl get nodes -oname); do kubectl taint nodes $node key:NoSchedule-; done

/close

[knative-prow-robot]

@jonjohnsonjr: Closing this issue.

In response to this:

Confirmed this was fixed by tainting all my nodes:

$ for node in $(kubectl get nodes -oname); do kubectl taint nodes $node key=value:NoSchedule; done

When trying to scale up a revision, I see this in the ksvc status:

 - lastTransitionTime: "2019-08-14T21:24:08Z"
   message: 'Revision "counter-gzhj8" failed with message: 0/2 nodes are available:
     2 node(s) had taints that the pod didn''t tolerate..'
   reason: RevisionFailed
   status: "False"
   type: Ready

🎉

To untaint the nodes:

$ for node in $(kubectl get nodes -oname); do kubectl taint nodes $node key:NoSchedule-; done

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.