Add KReference.Group field and ResolveGroup function #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
|
/hold |
knative-prow-robot
added
do-not-merge/hold
Codecov Report
@@ Coverage Diff @@
## main #2127 +/- ##
==========================================
+ Coverage 67.44% 67.66% +0.22%
==========================================
Files 215 216 +1
Lines 9117 9130 +13
==========================================
+ Hits 6149 6178 +29
+ Misses 2695 2677 -18
- Partials 273 275 +2
Continue to review full report at Codecov.
|
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
This was referenced May 27, 2021
vaikas
reviewed
Jun 4, 2021
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
n3wscott
reviewed
Jun 7, 2021
Made ResolveGroup a util method, more than an instance method Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
|
/retest Metrics ut failure. |
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
|
/unhold This has been approved per https://groups.google.com/g/knative-dev/c/lQ1E4q9s1Ig/m/dQTif0xzBQAJ |
knative-prow-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, matzew, slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Francesco Guardiani francescoguard@gmail.com
Add the
KReference.Groupfield andResolveGroupfunction. Part of the experimental feature knative/eventing#5086Changes