Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the configuration of labels and annotations for the namespace #1899

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

houshengbo
Copy link
Contributor

Fixed: #388

@knative-prow knative-prow bot requested a review from aliok September 27, 2024 20:31
Copy link

knative-prow bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested a review from matzew September 27, 2024 20:31
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Project coverage is 66.49%. Comparing base (2b39ab1) to head (8741ad2).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/reconciler/common/namespace.go 80.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1899      +/-   ##
==========================================
+ Coverage   66.31%   66.49%   +0.17%     
==========================================
  Files          53       54       +1     
  Lines        2084     2107      +23     
==========================================
+ Hits         1382     1401      +19     
- Misses        587      589       +2     
- Partials      115      117       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@houshengbo houshengbo changed the title Implement the configuration for labels and annotations Implement the configuration of labels and annotations for the namespace Oct 10, 2024
@houshengbo houshengbo added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2024
@knative-prow knative-prow bot merged commit 36698cc into knative:main Oct 10, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Knative Installation Wipes Namespace Labels (Should Merge)
1 participant