Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.11] Make the helm charts as a base template to scaffold the artifacts #1512

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #1501

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 31, 2023
@knative-prow knative-prow bot requested review from aliok and houshengbo July 31, 2023 21:40
@houshengbo
Copy link
Contributor

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2023
@upodroid
Copy link
Member

/hold

let the nightly run and see if your changes worked

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0575636) 79.22% compared to head (ce87471) 79.22%.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.11    #1512   +/-   ##
=============================================
  Coverage         79.22%   79.22%           
=============================================
  Files                40       40           
  Lines              1800     1800           
=============================================
  Hits               1426     1426           
  Misses              272      272           
  Partials            102      102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@houshengbo
Copy link
Contributor

/test eventing-upgrade-tests

Copy link
Contributor

@houshengbo houshengbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold As the nightly build passes, unhold this PR to merge into release-1.11.

@houshengbo houshengbo removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2023
@knative-prow knative-prow bot merged commit 4540ae8 into knative:release-1.11 Aug 1, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants