-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use kubeVersion to constrain kubernetes version when using helm #1503
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hhk7734 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Hyeonki Hong <hhk7734@gmail.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1503 +/- ##
=======================================
Coverage 79.15% 79.15%
=======================================
Files 40 40
Lines 1794 1794
=======================================
Hits 1420 1420
Misses 272 272
Partials 102 102 ☔ View full report in Codecov by Sentry. |
@hhk7734: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@hhk7734 The reason I put it in values is to make it configurable by different platforms. Like in my clusters, I need to override this value. |
@houshengbo Is it better to leave both As an additional question, is there a reason for using |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Proposed Changes
I moved the Kubernetes version restriction from values.yaml to Chart.yaml because I thought it would be nice to be limited by Helm.