Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kubeVersion to constrain kubernetes version when using helm #1503

Closed
wants to merge 1 commit into from
Closed

Conversation

hhk7734
Copy link
Member

@hhk7734 hhk7734 commented Jul 26, 2023

Proposed Changes

I moved the Kubernetes version restriction from values.yaml to Chart.yaml because I thought it would be nice to be limited by Helm.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 26, 2023
@knative-prow knative-prow bot requested review from aliok and maximilien July 26, 2023 15:38
@knative-prow
Copy link

knative-prow bot commented Jul 26, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hhk7734
Once this PR has been reviewed and has the lgtm label, please assign psschwei for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Hyeonki Hong <hhk7734@gmail.com>
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8129f02) 79.15% compared to head (12db174) 79.15%.
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1503   +/-   ##
=======================================
  Coverage   79.15%   79.15%           
=======================================
  Files          40       40           
  Lines        1794     1794           
=======================================
  Hits         1420     1420           
  Misses        272      272           
  Partials      102      102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow
Copy link

knative-prow bot commented Jul 26, 2023

@hhk7734: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
eventing-upgrade-tests_operator_main 12db174 link true /test eventing-upgrade-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@houshengbo
Copy link
Contributor

@hhk7734 The reason I put it in values is to make it configurable by different platforms. Like in my clusters, I need to override this value.

@hhk7734
Copy link
Member Author

hhk7734 commented Jul 28, 2023

@houshengbo Is it better to leave both kubeVersion and kubernetes_min_version? Or should I close this PR?

As an additional question, is there a reason for using snake case? Most of the helm charts I've seen so far are in camel case, so it feels out of place. Also, I'm wondering if there's a reason why the apiVersion is v1. I know v1 is recognized by helm3, but I don't see the need to support older versions.

https://helm.sh/docs/topics/version_skew/

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2023
@knative-prow-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hhk7734 hhk7734 closed this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants