Validate usage of knative.dev/hack/shell #32
Conversation
knative-prow-robot
added
the
size/M
cardil
force-pushed
the
followup/30-validate-shellout-usage
branch
from
e957121 to
f4ed6bd
Compare
This is follow up to knative.dev/hack#30 intended to disallow using this shell out package without control. If new place is required to use this package, first a allow PR should be made to this repo.
cardil
force-pushed
the
followup/30-validate-shellout-usage
branch
from
f4ed6bd to
1f1f81b
Compare
|
What do you think of this solution, to block not allowed usages @n3wscott ? |
| "knative.dev/hack/shell" | ||
| ) | ||
|
|
||
| func TestCallerNotAllowed(t *testing.T) { |
There was a problem hiding this comment.
I think it just needs the deprecated comment, this test will be removed in the vendoring process.
There was a problem hiding this comment.
Of course test will be removed.
But, there's a validation added to shell/project.go that will return error in used from not allowed location
There was a problem hiding this comment.
FWIW: Using deprecated comments will upset the linter.
There was a problem hiding this comment.
FWIW: Using deprecated comments will upset the linter.
That is the point. You have to opt-in to using the deprecated code
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, n3wscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
This is follow up to #30 intended to disallow using this shell out package without control.
If a new place is required to use this package, an "allow PR" should be made to this repo first.
/cc @n3wscott