Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to ssh-agent on Windows using named pipes #733

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

jrangelramos
Copy link
Contributor

Changes

  • 🐛 Enable use of ssh-agent on Windows thru named pipes on func build (when using a remote container engine thru ssh)

/kind enhancement

Fixes #732

@knative-prow-robot knative-prow-robot added kind/enhancement size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 23, 2021
@jrangelramos
Copy link
Contributor Author

/cc @matejvasek

@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #733 (b622b48) into main (7cf2b47) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #733   +/-   ##
=======================================
  Coverage   41.56%   41.56%           
=======================================
  Files          42       42           
  Lines        4083     4083           
=======================================
  Hits         1697     1697           
  Misses       2135     2135           
  Partials      251      251           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cf2b47...b622b48. Read the comment docs.

ssh/ssh_dialer.go Outdated Show resolved Hide resolved
@matejvasek
Copy link
Contributor

@jrangelramos please fix the CI errors.

@matejvasek
Copy link
Contributor

otherwise lgtm

@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2022
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrangelramos, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2022
@knative-prow-robot knative-prow-robot merged commit 3177287 into knative:main Jan 5, 2022
jrangelramos pushed a commit to jrangelramos/func that referenced this pull request Feb 1, 2024
* chore: update quarkus version

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* Update 0002-quarkus-productized.patch

---------

Signed-off-by: Matej Vasek <mvasek@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use ssh-agent thru named pipes on Windows
3 participants