Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] [DNM] From scratch #2671

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[WIP] [DNM] From scratch #2671

wants to merge 2 commits into from
+547 −1

Conversation

matejvasek
Copy link
Contributor

Changes

/kind

Fixes #

Release Note

Docs

@matejvasek
Fixed pod readiness check
079db29 
Detect also if pod did not exited prematurely.

Signed-off-by: Matej Vašek <mvasek@redhat.com>
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 23, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 23, 2025

@matejvasek: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from jrangelramos and rhuss January 23, 2025 18:26
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 23, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 23, 2025
View reviewed changes
cmd/func-util/main.go Fixed Show fixed Hide fixed
cmd/func-util/main.go Fixed Show fixed Hide fixed
cmd/func-util/main.go Fixed Show fixed Hide fixed
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 51.35135% with 36 lines in your changes missing coverage. Please review.

Project coverage is 62.33%. Comparing base (20a173a) to head (b9bd1cb).

Files with missing lines Patch % Lines
pkg/tar/tar.go 55.07% 22 Missing and 9 partials ⚠️
pkg/k8s/dialer.go 0.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2671      +/-   ##
==========================================
- Coverage   64.16%   62.33%   -1.84%     
==========================================
  Files         130      129       -1     
  Lines       15519    15584      +65     
==========================================
- Hits         9958     9714     -244     
- Misses       4622     4929     +307     
- Partials      939      941       +2
Flag Coverage Δ
e2e-test 35.84% <0.00%> (-0.02%) ⬇️
e2e-test-oncluster ?
e2e-test-oncluster-runtime 28.46% <0.00%> (?)
e2e-test-runtime-go 26.43% <0.00%> (?)
e2e-test-runtime-node 25.83% <0.00%> (?)
e2e-test-runtime-python 25.83% <0.00%> (?)
e2e-test-runtime-quarkus 25.98% <0.00%> (?)
e2e-test-runtime-rust 24.91% <0.00%> (?)
e2e-test-runtime-typescript 25.94% <0.00%> (?)
integration-tests ?
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek matejvasek removed the request for review from rhuss January 23, 2025 18:37
@matejvasek matejvasek force-pushed the from-scratch branch 2 times, most recently from 74f1ab8 to 2f528db Compare January 23, 2025 19:12
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 23, 2025
@matejvasek matejvasek force-pushed the from-scratch branch 3 times, most recently from 39ae38a to 3b48ccc Compare January 24, 2025 02:07
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 24, 2025
View reviewed changes
cmd/func-util/main.go Fixed Show fixed Hide fixed
cmd/func-util/main.go Fixed Show fixed Hide fixed
cmd/func-util/main.go Fixed Show fixed Hide fixed
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 24, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 24, 2025
View reviewed changes
pkg/tar/tar.go Fixed Show fixed Hide fixed
pkg/tar/tar.go Fixed Show fixed Hide fixed
pkg/tar/tar.go
case hdr.Typeflag == tar.TypeDir:
err = os.MkdirAll(targetPath, os.FileMode(hdr.Mode)&fs.ModePerm)
case hdr.Typeflag == tar.TypeSymlink:
err = os.Symlink(hdr.Linkname, targetPath)

Check failure

Code scanning / CodeQL

Arbitrary file write extracting an archive containing symbolic links High

Unresolved path from an archive header, which may point outside the archive root, is used in
symlink creation
Loading
.
@matejvasek matejvasek force-pushed the from-scratch branch 2 times, most recently from 36c2fc7 to 163dd3b Compare January 24, 2025 20:06
@matejvasek
Removed dependency on sh/tar from alpine image
b9bd1cb 
This commit removes depencency on sh and tar binaries by implementing
the logic in our func-util binary.

Signed-off-by: Matej Vašek <mvasek@redhat.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 24, 2025
View reviewed changes
pkg/tar/tar.go
}

var targetPath, rel string
targetPath = filepath.Join(targetDir, filepath.FromSlash(hdr.Name))

Check failure

Code scanning / CodeQL

Arbitrary file write extracting an archive containing symbolic links High

Unresolved path from an archive header, which may point outside the archive root, is used in
symlink creation
Loading
.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matejvasek