Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: struct naming in instanced go http templates synced #2670

Merged
merged 2 commits into from
Jan 31, 2025
Merged

fix: struct naming in instanced go http templates synced #2670

merged 2 commits into from
Jan 31, 2025

Conversation

gauron99
Copy link
Contributor

@gauron99 gauron99 commented Jan 23, 2025 •
edited
Loading

match the struct MyFunction

@knative-prow knative-prow bot requested review from dsimansk and nainaz January 23, 2025 17:20
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 23, 2025
@gauron99 gauron99 changed the title fix: Method names should match the struct fix: struct naming in instanced go http templates synced Jan 23, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.35%. Comparing base (4b1cc39) to head (f8e9dc3).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2670      +/-   ##
==========================================
+ Coverage   64.07%   65.35%   +1.27%     
==========================================
  Files         131      131              
  Lines       15601    15601              
==========================================
+ Hits         9997    10196     +199     
+ Misses       4653     4417     -236     
- Partials      951      988      +37
Flag Coverage Δ
e2e-test 35.79% <ø> (ø)
e2e-test-oncluster 34.20% <ø> (+1.33%) ⬆️
e2e-test-oncluster-runtime 28.64% <ø> (?)
e2e-test-runtime-go 26.43% <ø> (?)
e2e-test-runtime-node 25.83% <ø> (?)
e2e-test-runtime-python 25.83% <ø> (?)
e2e-test-runtime-quarkus 25.98% <ø> (?)
e2e-test-runtime-rust 24.91% <ø> (?)
e2e-test-runtime-springboot 24.97% <ø> (?)
e2e-test-runtime-typescript 25.94% <ø> (?)
integration-tests 52.00% <ø> (+2.24%) ⬆️
unit-tests 50.96% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lkingland
lkingland approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2025
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2025
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2025
@gauron99
Copy link
Contributor Author

@lkingland pls LGTM again

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2025
@gauron99
sync names
4b7df20 
Signed-off-by: David Fridrich <fridrich.david19@gmail.com>
@gauron99
zz
f8e9dc3 
Signed-off-by: David Fridrich <fridrich.david19@gmail.com>
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2025
@gauron99
Copy link
Contributor Author

@lkingland @matejvasek PTAL pls

@matejvasek
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2025
@gauron99
Copy link
Contributor Author

/retest unit-tests_func_main

@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 31, 2025

@gauron99: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test unit-tests

Use /test all to run all jobs.

In response to this:

/retest unit-tests_func_main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gauron99
Copy link
Contributor Author

/retest required

@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 31, 2025

@gauron99: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test unit-tests

Use /test all to run all jobs.

In response to this:

/retest required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gauron99
Copy link
Contributor Author

/test required

@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 31, 2025

@gauron99: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test unit-tests

Use /test all to run all jobs.

In response to this:

/test required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gauron99
Copy link
Contributor Author

/test unit-tests

@knative-prow knative-prow bot merged commit 2228c9d into knative:main Jan 31, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkingland lkingland lkingland approved these changes

@matejvasek matejvasek Awaiting requested review from matejvasek

Assignees

@matejvasek matejvasek

@lkingland lkingland

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gauron99 @matejvasek @lkingland @knative-prow-robot