-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: move non-oncluster test to e2e #2659
base: main
Are you sure you want to change the base?
test: move non-oncluster test to e2e #2659
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2659 +/- ##
==========================================
- Coverage 64.13% 62.21% -1.93%
==========================================
Files 130 128 -2
Lines 15518 15509 -9
==========================================
- Hits 9953 9649 -304
- Misses 4625 4909 +284
- Partials 940 951 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b5ca91d
to
94ef7ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
(assuming the e2e test succeeds, which I re-ran)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jrangelramos, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
/kind cleanup