Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Upgrade to latest dependencies #2658

Merged
merged 1 commit into from
Jan 18, 2025
Merged

[main] Upgrade to latest dependencies #2658

merged 1 commit into from
Jan 18, 2025

Conversation

knative-automation
Copy link
Contributor

Cron -knative-prow-robot

/cc knative/func-approvers
/assign knative/func-approvers

Produced by: knative-extensions/knobots/actions/update-deps

@knative-automation
upgrade to latest dependencies
5bb4ab0 
bumping knative.dev/eventing 90edfe6...a40a0a7:
  > a40a0a7 [main] Upgrade to latest dependencies (# 8413)
bumping knative.dev/pkg 0c2a238...c43477f:
  > c43477f upgrade to latest dependencies (# 3137)

Signed-off-by: Knative Automation <automation@knative.team>
@knative-automation knative-automation force-pushed the auto-updates/update-deps-main branch from 3822810 to 5bb4ab0 Compare January 17, 2025 13:17
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 17, 2025

@knative-automation: GitHub didn't allow me to request PR reviews from the following users: knative/func-approvers.

Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Cron -knative-prow-robot

/cc knative/func-approvers
/assign knative/func-approvers

Produced by: knative-extensions/knobots/actions/update-deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 17, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.42%. Comparing base (02b331d) to head (5bb4ab0).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2658      +/-   ##
==========================================
+ Coverage   64.13%   65.42%   +1.28%     
==========================================
  Files         130      130              
  Lines       15518    15518              
==========================================
+ Hits         9953    10152     +199     
+ Misses       4625     4389     -236     
- Partials      940      977      +37
Flag Coverage Δ
e2e-test 35.81% <ø> (ø)
e2e-test-oncluster 32.90% <ø> (+0.10%) ⬆️
e2e-test-oncluster-runtime 28.65% <ø> (?)
e2e-test-runtime-go 26.44% <ø> (?)
e2e-test-runtime-node 25.84% <ø> (?)
e2e-test-runtime-python 25.84% <ø> (?)
e2e-test-runtime-quarkus 25.99% <ø> (?)
e2e-test-runtime-rust 24.94% <ø> (?)
e2e-test-runtime-springboot 24.96% <ø> (?)
e2e-test-runtime-typescript 25.95% <ø> (?)
integration-tests 52.00% <ø> (+2.33%) ⬆️
unit-tests 50.93% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lkingland
lkingland approved these changes Jan 18, 2025
View reviewed changes
Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
(assuming the e2e succeeds this time, which I just re-ran)

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-automation, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2025
@knative-prow knative-prow bot merged commit 68cd559 into knative:main Jan 18, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkingland lkingland lkingland approved these changes

Assignees

@lkingland lkingland

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knative-automation @lkingland