Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide tiny buildpack builder image for ARM64 #2617

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

matejvasek
Copy link
Contributor

Enable arm64 support for tiny builder (Java,Go).
This PR actually enables only Java since some additional work has to be done for Go because upstream paketo buildpack do not support Go fully yet.

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 17, 2024
@knative-prow knative-prow bot requested review from nainaz and vyasgun December 17, 2024 00:15
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2024
@matejvasek matejvasek requested review from lkingland, jrangelramos and gauron99 and removed request for nainaz and vyasgun December 17, 2024 00:15
@matejvasek
Copy link
Contributor Author

@matejvasek matejvasek requested a review from matzew December 17, 2024 00:16
Enable arm64 support for tiny builder (Java,Go).
This commit actually enables only Java since some additinal work has to
be done for Go because upstream paketo buildpack do not support Go fully
yet.

Signed-off-by: Matej Vašek <mvasek@redhat.com>
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.37%. Comparing base (70f96bb) to head (768390f).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2617      +/-   ##
==========================================
+ Coverage   64.16%   65.37%   +1.21%     
==========================================
  Files         130      130              
  Lines       15518    15518              
==========================================
+ Hits         9957    10145     +188     
+ Misses       4622     4397     -225     
- Partials      939      976      +37     
Flag Coverage Δ
e2e-test 35.81% <ø> (ø)
e2e-test-oncluster 32.87% <ø> (ø)
e2e-test-oncluster-runtime 28.65% <ø> (?)
e2e-test-runtime-springboot 24.98% <ø> (?)
integration-tests 51.98% <ø> (+2.27%) ⬆️
unit-tests 50.93% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek matejvasek changed the title Build arm64 tiny buildpack builder image Provide tiny buildpack builder image for ARM64 Dec 17, 2024
@matejvasek
Copy link
Contributor Author

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024
Copy link

knative-prow bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit d5dc82c into knative:main Dec 18, 2024
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants