Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use knative go setup action #2612

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

lkingland
Copy link
Member

@lkingland lkingland commented Dec 13, 2024

Keeps the Go version used by Knative projects in sync with each-other and tooling.

/kind cleanup

Keeps the Go version used by Knative projects in sync with each-other
and tooling.
@knative-prow knative-prow bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 13, 2024
@knative-prow knative-prow bot requested review from dsimansk and rhuss December 13, 2024 02:21
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.42%. Comparing base (6384d07) to head (f19341d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2612      +/-   ##
==========================================
+ Coverage   64.13%   65.42%   +1.28%     
==========================================
  Files         130      130              
  Lines       15518    15518              
==========================================
+ Hits         9953    10152     +199     
+ Misses       4625     4389     -236     
- Partials      940      977      +37     
Flag Coverage Δ
e2e-test 35.81% <ø> (ø)
e2e-test-oncluster 32.90% <ø> (+0.02%) ⬆️
e2e-test-oncluster-runtime 28.65% <ø> (?)
e2e-test-runtime-go 26.44% <ø> (?)
e2e-test-runtime-node 25.84% <ø> (?)
e2e-test-runtime-python 25.84% <ø> (?)
e2e-test-runtime-quarkus 25.97% <ø> (?)
e2e-test-runtime-rust 24.94% <ø> (?)
e2e-test-runtime-springboot 24.98% <ø> (?)
e2e-test-runtime-typescript 25.95% <ø> (?)
integration-tests 51.95% <ø> (+2.25%) ⬆️
unit-tests 50.93% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member

/lgtm
/approve

there's a github warning about another outdated action - I'd suggest a follow up PR.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2024
Copy link

knative-prow bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit b033bb5 into knative:main Dec 13, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants