Fix symlink path separators #2535
Conversation
When running on Windows the path separators in symlink target is backslash. This must be fixed up when uploading source code into docker daemon or into cluster volume. Signed-off-by: Matej Vašek <matejvasek@gmail.com>
|
@matejvasek: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
knative-prow
bot
added
the
size/XS
matejvasek
requested review from
matzew,
gauron99 and
lkingland
and removed request for
nainaz
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2535 +/- ##
==========================================
+ Coverage 60.63% 66.91% +6.28%
==========================================
Files 130 130
Lines 15465 12036 -3429
==========================================
- Hits 9377 8054 -1323
+ Misses 5180 3007 -2173
- Partials 908 975 +67
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@jrangelramos please verify this fixes the issue. |
|
/lgtm |
When running on Windows the path separators in symlink target is backslash. This must be fixed up when uploading source code into docker daemon or into cluster volume. Signed-off-by: Matej Vašek <matejvasek@gmail.com>
When running on Windows the path separators in symlink target is backslash. This must be fixed up when uploading source code into docker daemon or into cluster volume. Signed-off-by: Matej Vašek <matejvasek@gmail.com>
Changes
When running on Windows the path separators in symlink target is backslash. This must be fixed up when uploading source code into docker daemon or into cluster volume.
Fixes #2529
/kind bug