Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: create whole config path if it doesnt exist yet #2490

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

gauron99
Copy link
Contributor

If the func config path doesnt exist at all yet, create it here, where strictly necessary.
WriteFile will create the auth.json file if necessary, but not the whole path.

Signed-off-by: David Fridrich <fridrich.david19@gmail.com>
Signed-off-by: David Fridrich <fridrich.david19@gmail.com>
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2024
@knative-prow knative-prow bot requested review from rhuss and vyasgun September 10, 2024 12:12
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.06%. Comparing base (8dce9bc) to head (2e2da73).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/docker/creds/credentials.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2490      +/-   ##
==========================================
+ Coverage   61.54%   67.06%   +5.52%     
==========================================
  Files         129      129              
  Lines       15340    11934    -3406     
==========================================
- Hits         9441     8004    -1437     
+ Misses       4972     2966    -2006     
- Partials      927      964      +37     
Flag Coverage Δ
e2e-test 36.60% <0.00%> (-0.01%) ⬇️
e2e-test-oncluster 33.34% <0.00%> (-0.07%) ⬇️
e2e-test-oncluster-runtime 29.52% <0.00%> (?)
e2e-test-runtime-go 26.61% <0.00%> (?)
e2e-test-runtime-node 26.00% <0.00%> (?)
e2e-test-runtime-python 26.00% <0.00%> (?)
e2e-test-runtime-quarkus 26.09% <0.00%> (?)
e2e-test-runtime-rust 25.14% <0.00%> (?)
e2e-test-runtime-springboot 25.15% <0.00%> (?)
e2e-test-runtime-typescript 26.08% <0.00%> (?)
integration-tests 53.11% <0.00%> (+2.36%) ⬆️
unit-tests 51.29% <33.33%> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2024
Copy link

knative-prow bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 92856e5 into knative:main Sep 10, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants