Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved ldflags setting in Makefile #2488

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

matejvasek
Copy link
Contributor

Changes

  • Improved ldflags setting in Makefile

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
Copy link

knative-prow bot commented Sep 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2024
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 9, 2024
@matejvasek matejvasek requested review from matzew, gauron99 and lkingland and removed request for jrangelramos and vyasgun September 9, 2024 12:46
@matejvasek
Copy link
Contributor Author

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.06%. Comparing base (8dce9bc) to head (edfbc2b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2488      +/-   ##
==========================================
+ Coverage   61.54%   67.06%   +5.51%     
==========================================
  Files         129      129              
  Lines       15340    11931    -3409     
==========================================
- Hits         9441     8001    -1440     
+ Misses       4972     2966    -2006     
- Partials      927      964      +37     
Flag Coverage Δ
e2e-test 36.61% <ø> (ø)
e2e-test-oncluster 33.42% <ø> (+<0.01%) ⬆️
e2e-test-oncluster-runtime 29.46% <ø> (?)
e2e-test-runtime-go 26.62% <ø> (?)
e2e-test-runtime-node 26.00% <ø> (?)
e2e-test-runtime-python 26.00% <ø> (?)
e2e-test-runtime-quarkus 26.10% <ø> (?)
e2e-test-runtime-rust 25.12% <ø> (?)
e2e-test-runtime-springboot 25.18% <ø> (?)
e2e-test-runtime-typescript 26.07% <ø> (?)
integration-tests 53.13% <ø> (+2.38%) ⬆️
unit-tests 51.28% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jrangelramos
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2024
@knative-prow knative-prow bot merged commit a965c0f into knative:main Sep 9, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants