Remove superfluous equals sign from envvar #2446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matejvasek
commented
Jul 26, 2024
•
matejvasek
commented
- Remove superfluous equals sign from envvar from release script.
- Updated deps for Rust templates.
Signed-off-by: Matej Vašek <matejvasek@gmail.com>
knative-prow
bot
added
approved
matejvasek
requested review from
matzew,
jrangelramos and
gauron99
and removed request for
vyasgun
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2446 +/- ##
==========================================
+ Coverage 60.39% 66.70% +6.30%
==========================================
Files 130 130
Lines 15354 11940 -3414
==========================================
- Hits 9273 7964 -1309
+ Misses 5186 3013 -2173
- Partials 895 963 +68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Matej Vašek <matejvasek@gmail.com>
knative-prow
bot
added
size/XXL
|
/retest |
|
PTAL @jrangelramos |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csantanapr, jrangelramos, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gauron99
pushed a commit
to gauron99/func
that referenced
this pull request
Aug 26, 2024
* Remove superfluous equals sign from envvar Signed-off-by: Matej Vašek <matejvasek@gmail.com> * Update rust templates Cargo.lock Signed-off-by: Matej Vašek <matejvasek@gmail.com> --------- Signed-off-by: Matej Vašek <matejvasek@gmail.com>
knative-prow bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
* test: adding GO s2i to e2e test suite (#2401) * Remove superfluous equals sign from envvar (#2446) * Remove superfluous equals sign from envvar Signed-off-by: Matej Vašek <matejvasek@gmail.com> * Update rust templates Cargo.lock Signed-off-by: Matej Vašek <matejvasek@gmail.com> --------- Signed-off-by: Matej Vašek <matejvasek@gmail.com> * allow digested images to be 'run' (#2445) * init fix Signed-off-by: gauron99 <fridrich.david19@gmail.com> * dont override direct deploy tag, more tests Signed-off-by: gauron99 <fridrich.david19@gmail.com> * fix Signed-off-by: gauron99 <fridrich.david19@gmail.com> * dont validate with tagged image, fix comment Signed-off-by: gauron99 <fridrich.david19@gmail.com> * init run fix for --image Signed-off-by: gauron99 <fridrich.david19@gmail.com> * init Signed-off-by: gauron99 <fridrich.david19@gmail.com> * int test, add valid untdigested images to run Signed-off-by: gauron99 <fridrich.david19@gmail.com> * check images passed to runner for func run command Signed-off-by: gauron99 <fridrich.david19@gmail.com> * fix build/deploy image passing bug add test Signed-off-by: gauron99 <fridrich.david19@gmail.com> * fix Signed-off-by: gauron99 <fridrich.david19@gmail.com> * remove extra printing Signed-off-by: gauron99 <fridrich.david19@gmail.com> * merge functions to digested Signed-off-by: gauron99 <fridrich.david19@gmail.com> * misspell Signed-off-by: gauron99 <fridrich.david19@gmail.com> * simplify Signed-off-by: David Fridrich <fridrich.david19@gmail.com> * quick fix Signed-off-by: David Fridrich <fridrich.david19@gmail.com> * remove prints, comment Signed-off-by: David Fridrich <fridrich.david19@gmail.com> --------- Signed-off-by: gauron99 <fridrich.david19@gmail.com> Signed-off-by: David Fridrich <fridrich.david19@gmail.com> * On cluster s2i build for Go (alternative version) (#2471) * Prepare util image to accomodate multiple cmds As of now func-util image has only one command of our own -- "deploy". This commits prepares grounds for one additional command named "scaffolding". The commands will be implemented in one binary and dispatched over argv[0] using symlinks. Kinda like busybox does. Signed-off-by: Matej Vašek <matejvasek@gmail.com> * Add scaffolding for on-cluster build Added new build step in tekton pipeline that scaffolds main() for Go porject when using s2i builder. Signed-off-by: Matej Vašek <matejvasek@gmail.com> * Better docker build caching This will cache dependencies between docker builds. Signed-off-by: Matej Vašek <matejvasek@gmail.com> * fixup: perms Signed-off-by: Matej Vašek <matejvasek@gmail.com> * fixup: remove broken check Signed-off-by: Matej Vašek <matejvasek@gmail.com> * fixup: remove test because of 'no space left on device' Signed-off-by: Matej Vašek <matejvasek@gmail.com> * Make func-util rootfull Signed-off-by: Matej Vašek <matejvasek@gmail.com> --------- Signed-off-by: Matej Vašek <matejvasek@gmail.com> * Incorporate s2i CLI into func-utils image. (#2473) Signed-off-by: Matej Vašek <matejvasek@gmail.com> * chore: update Quarkus platform version to 3.14.1 (#2474) Co-authored-by: Knative Automation <automation@knative.team> Signed-off-by: Matej Vašek <matejvasek@gmail.com> * chore: update Springboot platform version to 3.3.3 (#2465) Co-authored-by: Knative Automation <automation@knative.team> Signed-off-by: Matej Vašek <matejvasek@gmail.com> --------- Signed-off-by: Matej Vašek <matejvasek@gmail.com> Signed-off-by: gauron99 <fridrich.david19@gmail.com> Signed-off-by: David Fridrich <fridrich.david19@gmail.com> Co-authored-by: Jefferson Ramos <jeramos@redhat.com> Co-authored-by: David Fridrich <49119790+gauron99@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Knative Automation <automation@knative.team>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.