Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.12] Bump for GO-GIT 5.11 #2133

Merged
merged 4 commits into from
Jan 24, 2024

Conversation

matzew
Copy link
Member

@matzew matzew commented Jan 24, 2024

Changes

/kind

Fixes #

Release Note


Docs


Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Copy link

knative-prow bot commented Jan 24, 2024

@matzew: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot requested review from dsimansk and maximilien January 24, 2024 06:12
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cd0bc6a) 58.39% compared to head (c989946) 61.58%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.12    #2133      +/-   ##
================================================
+ Coverage         58.39%   61.58%   +3.19%     
================================================
  Files               106      105       -1     
  Lines             13693    13691       -2     
================================================
+ Hits               7996     8432     +436     
+ Misses             4905     4404     -501     
- Partials            792      855      +63     
Flag Coverage Δ
e2e-test ?
e2e-test-oncluster 30.50% <ø> (?)
e2e-test-oncluster-runtime 26.72% <ø> (?)
e2e-test-runtime-springboot 25.73% <ø> (?)
integration-tests 51.95% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 24, 2024
@matejvasek
Copy link
Contributor

@matzew some test are failing.

Signed-off-by: Matej Vasek <mvasek@redhat.com>
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
@matejvasek
Copy link
Contributor

I updated linter.

@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
Update to URL used in newer versions of GitLab.

Signed-off-by: Matej Vasek <mvasek@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
Copy link

knative-prow bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 4b6247d into knative:release-1.12 Jan 24, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants