Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: springboot version auto-updater #2132

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

matejvasek
Copy link
Contributor

No description provided.

Signed-off-by: Matej Vasek <mvasek@redhat.com>
@knative-prow knative-prow bot requested review from maximilien and rhuss January 23, 2024 17:03
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 23, 2024
@matejvasek matejvasek requested review from trisberg, matzew, gauron99 and lkingland and removed request for maximilien and rhuss January 23, 2024 17:03
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ca64536) 64.13% compared to head (5554660) 65.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2132      +/-   ##
==========================================
+ Coverage   64.13%   65.16%   +1.03%     
==========================================
  Files         108      108              
  Lines       13919    13919              
==========================================
+ Hits         8927     9071     +144     
+ Misses       4116     3950     -166     
- Partials      876      898      +22     
Flag Coverage Δ
e2e-test 37.37% <ø> (ø)
e2e-test-oncluster 30.58% <ø> (+0.02%) ⬆️
e2e-test-oncluster-runtime 26.82% <ø> (?)
e2e-test-runtime-go 25.55% <ø> (?)
e2e-test-runtime-node 26.57% <ø> (?)
e2e-test-runtime-python 26.57% <ø> (?)
e2e-test-runtime-quarkus 26.68% <ø> (?)
e2e-test-runtime-rust 25.57% <ø> (?)
e2e-test-runtime-springboot 25.71% <ø> (?)
e2e-test-runtime-typescript 26.68% <ø> (?)
integration-tests 51.85% <ø> (+1.98%) ⬆️
unit-tests-macos-latest 48.85% <ø> (?)
unit-tests-ubuntu-latest 49.59% <ø> (?)
unit-tests-windows-latest 48.86% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
Copy link
Contributor Author

@matzew @lkingland PTAL

@matejvasek matejvasek changed the title fix: sprintboot version auto-updater fix: springboot version auto-updater Jan 23, 2024
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
Copy link

knative-prow bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 2f3a048 into knative:main Jan 24, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants