Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup orphaned func, new image-name calculation #1962

Merged
merged 53 commits into from
Feb 27, 2024
Merged
Changes from 1 commit
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
0807950
forced namespace change, deletes old func, kind works
gauron99 Sep 4, 2023
0f6c92f
new .deploy.image field
gauron99 Sep 4, 2023
e3fe80d
building
gauron99 Oct 10, 2023
3a6fdb3
building
gauron99 Oct 10, 2023
c87167e
add first iteration of complete functionality with f.Build.Image and …
gauron99 Nov 1, 2023
fdf34f9
base tests fixes for compile
gauron99 Nov 1, 2023
35d1916
fix base tests2 for now, integration test has a possible TODO
gauron99 Nov 1, 2023
2b1ba95
new generated schema
gauron99 Nov 1, 2023
318b376
fix some tests using .Image and create new test
gauron99 Nov 6, 2023
4f061ce
remove nested .func
gauron99 Nov 6, 2023
00cd46f
get rid of test
gauron99 Nov 7, 2023
2d3dfa3
remove my debug test
gauron99 Nov 13, 2023
c81a191
fix namespace change test
gauron99 Nov 13, 2023
6cacae4
fix pipeline run to use .Deploy.Image
gauron99 Nov 13, 2023
3e4a773
fix TestDeploy_ConfigApplied and change pipelines image being used
gauron99 Nov 14, 2023
ec6dd06
fix some tests
gauron99 Nov 27, 2023
29008ab
fix actions - return value, configApplied and registry on subsequent …
gauron99 Dec 4, 2023
809adf7
update empty image in tests issue
gauron99 Dec 8, 2023
a2abf0c
fix client.Apply tests with passing image value to .Deploy after push
gauron99 Dec 9, 2023
4b4305b
openshift override on namespace change forced, remove useless print
gauron99 Dec 10, 2023
37e810a
printing fixes, reviewdog, buildConfig return
gauron99 Dec 10, 2023
4e1f4f5
fix pipelines test by feeding image name to .Deploy, comments
gauron99 Dec 11, 2023
434cc0e
update more tests
gauron99 Dec 12, 2023
b7478b0
fix
gauron99 Dec 12, 2023
971e735
new test, comment
gauron99 Dec 12, 2023
070dcde
misspell
gauron99 Dec 12, 2023
b5a7bde
remove unnecessary comments
gauron99 Dec 13, 2023
2c48fee
fix from review
gauron99 Jan 2, 2024
2225fff
namespace updated with 2 fields; new error definitions; deploy functi…
gauron99 Jan 10, 2024
c18bc76
remove k8s service host var in test
gauron99 Jan 10, 2024
c809be5
error definition; fix client tests; cli delete fixup
gauron99 Jan 10, 2024
a1e193c
new schema
gauron99 Jan 10, 2024
75fbd28
namespace fixes; remover arguments fix
gauron99 Jan 22, 2024
5054422
delete_test cmd
gauron99 Jan 22, 2024
ce899c0
schema, new local remote flag instead of deploy
gauron99 Jan 22, 2024
3fe827a
fix test to have now required namespace
gauron99 Jan 25, 2024
8465c80
add namespace check, test action
gauron99 Jan 29, 2024
e5e5f2f
fix integration deploy test, comments
gauron99 Jan 30, 2024
6d9c667
fix wrongly removed namespace
gauron99 Jan 30, 2024
b19613b
small changes to remover and ns added to its tests
gauron99 Jan 31, 2024
4691a76
test moving logic to client
gauron99 Feb 1, 2024
5dc0ecc
fix deploy bug, remove verbose for better logs
gauron99 Feb 1, 2024
3f32aae
pipelines, clean remover
gauron99 Feb 2, 2024
76e606e
newline
gauron99 Feb 4, 2024
e3b8599
namespace required in remover, and fixed remote deployer - returns ns
gauron99 Feb 4, 2024
686fcee
fix integ test for pipelines.Run
gauron99 Feb 4, 2024
8a9de10
cleanup
gauron99 Feb 6, 2024
9d1d9f0
registry update change on deploy, some prints
gauron99 Feb 8, 2024
9b506cd
new deploy tests and mock update
gauron99 Feb 9, 2024
507fb0c
new tests, ns determination in mocks
gauron99 Feb 12, 2024
db2176f
deploy digested img doesnt populate build
gauron99 Feb 12, 2024
716401b
comments
gauron99 Feb 19, 2024
5cb7e1a
remove todo
gauron99 Feb 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix wrongly removed namespace
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
gauron99 committed Feb 27, 2024
commit 6d9c6670d168771bd6697a16eb3699af552afa2d
2 changes: 1 addition & 1 deletion pkg/functions/client_int_test.go
Original file line number Diff line number Diff line change
@@ -586,7 +586,7 @@ func newClient(verbose bool) *fn.Client {
func del(t *testing.T, c *fn.Client, name string) {
t.Helper()
waitFor(t, c, name)
if err := c.Remove(context.Background(), fn.Function{Name: name}, false); err != nil {
if err := c.Remove(context.Background(), fn.Function{Name: name, Deploy: fn.DeploySpec{Namespace: DefaultNamespace}}, false); err != nil {
t.Fatal(err)
}
cli, _, err := docker.NewClient(client.DefaultDockerHost)