Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the ClusterRoleBindings, as they no longer give admin privileges. #986

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Rename the ClusterRoleBindings, as they no longer give admin privileges. #986

merged 1 commit into from
Mar 27, 2019

Conversation

Harwayne
Copy link
Contributor

@Harwayne Harwayne commented Mar 27, 2019 •
edited by grantr
Loading

Proposed Changes

  • Rename the ClusterRoleBindings, as they no longer give admin privileges.

Release Note

action required: Manually delete the old `eventing-controller-admin` ClusterRoleBinding.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 27, 2019
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 27, 2019
@Harwayne
Copy link
Contributor Author

/assign @vaikas-google

@vaikas
Copy link
Contributor

vaikas commented Mar 27, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Harwayne,vaikas-google]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit f29986c into knative:master Mar 27, 2019
@Harwayne Harwayne deleted the binding-name branch March 28, 2019 00:29
matzew added a commit to matzew/eventing that referenced this pull request Nov 19, 2020
@matzew
Adding some more backprts (knative#986)
6512367 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew Awaiting requested review from matzew

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@vaikas vaikas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Harwayne @vaikas @knative-prow-robot @googlebot