Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TTL to the Broker. #951

Merged
merged 6 commits into from
Mar 26, 2019
Merged

Conversation

Harwayne
Copy link
Contributor

Fixes #900

Proposed Changes

  • A given Event can only go through a Trigger's reply back into the Broker 10 times in a row. On the 11th iteration, the event will be dropped (accepted by the Ingress, but ignored).
    • Note that this only affects Trigger replies, not any requests made directly by the Trigger's Subscriber.
    • This is to prevent accidental infinite loops where a function replies with the event it consumed.
    • 10 is a hard coded default, but later we can make this part of the Broker's spec to allow customization.
  • Nothing outside of the Broker/Trigger infrastructure will ever see the TTL.

Release Note

An Event can flow through a Broker via Trigger replies only 10 times before getting dropped.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 21, 2019
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 21, 2019
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2019
@vaikas
Copy link
Contributor

vaikas commented Mar 26, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2019
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2019
@Harwayne
Copy link
Contributor Author

/test pull-knative-eventing-integration-tests

@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/broker/receiver.go 82.9% 84.8% 1.9
pkg/broker/ttl.go Do not exist 100.0%

@Harwayne
Copy link
Contributor Author

/test pull-knative-eventing-integration-tests

1 similar comment
@vaikas
Copy link
Contributor

vaikas commented Mar 26, 2019

/test pull-knative-eventing-integration-tests

@vaikas
Copy link
Contributor

vaikas commented Mar 26, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Harwayne,vaikas-google]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 0d410de into knative:master Mar 26, 2019
@Harwayne Harwayne deleted the broker-new-ttl-2 branch May 9, 2019 18:57
matzew added a commit to matzew/eventing that referenced this pull request Nov 6, 2020
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

Co-authored-by: Francesco Guardiani <francescoguard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants