Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.15] Schduler: MAXFILLUP strategy will spread vreplicas across multiple pods #8290

Merged
merged 7 commits into from
Oct 30, 2024
Merged

[release-1.15] Schduler: MAXFILLUP strategy will spread vreplicas across multiple pods #8290

merged 7 commits into from
Oct 30, 2024

Commits on Oct 30, 2024

  1. Schduler: MAXFILLUP strategy will spread vreplicas across multiple pods 

    the MAXFILLUP algorithm was using an affinity strategy, meaning that
it would prioritize adding new vreplicas to pods with the same resources.

However, the downside is that if one pod goes down or gets
re-scheduled the entire resource would be down and not produce
events. By spreading replicas across multiple real replicas we would
guarantee better availability.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
    @pierDipi @knative-prow-robot
    pierDipi authored and knative-prow-robot committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    5ef11db View commit details
    Browse the repository at this point in the history

  2. Remove configurable HA scheduler, fix reserved replicas logic 

    Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
    @pierDipi @knative-prow-robot
    pierDipi authored and knative-prow-robot committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    9675eb4 View commit details
    Browse the repository at this point in the history

  3. Log reserved 

    Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
    @pierDipi @knative-prow-robot
    pierDipi authored and knative-prow-robot committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    8c80447 View commit details
    Browse the repository at this point in the history

  4. Handle unschedulables pods and always start from reserved no matter w… 

    …hat is placements

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
    @pierDipi @knative-prow-robot
    pierDipi authored and knative-prow-robot committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    3b8a9a0 View commit details
    Browse the repository at this point in the history

  5. Add reserved + overcommit 

    Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
    @pierDipi @knative-prow-robot
    pierDipi authored and knative-prow-robot committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    455eb7d View commit details
    Browse the repository at this point in the history

  6. Add benchmark + reduce OrdinalFromPodName calls 

    Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
    @pierDipi @knative-prow-robot
    pierDipi authored and knative-prow-robot committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    2683abf View commit details
    Browse the repository at this point in the history

  7. Handle unschedulable pods 

    Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
    @pierDipi @knative-prow-robot
    pierDipi authored and knative-prow-robot committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    f4d8af8 View commit details
    Browse the repository at this point in the history