Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix env var indentation and grouping in contrib yamls #824

Merged
merged 2 commits into from
Feb 20, 2019
Merged

Fix env var indentation and grouping in contrib yamls #824

merged 2 commits into from
Feb 20, 2019

Conversation

evankanderson
Copy link
Member

Fixes #711

Proposed Changes

  • Fix env indentation for gcppubsub and natss ClusterChannelProvisioners.

Release Note

* Allow `gcp-pubsub.yaml` and `natss.yaml` to be built and released.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 20, 2019
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 20, 2019
@evankanderson evankanderson changed the title Indent indent indent Fix env var indentation and grouping in contrib yamls Feb 20, 2019
@vaikas
Copy link
Contributor

vaikas commented Feb 20, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [evankanderson,vaikas-google]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Harwayne
Harwayne reviewed Feb 20, 2019
View reviewed changes
Copy link
Contributor

@Harwayne Harwayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot merged commit 3086593 into master Feb 20, 2019
@evankanderson evankanderson mentioned this pull request Feb 20, 2019
Closed
evankanderson added a commit that referenced this pull request Feb 20, 2019
@evankanderson
Fix env vars from #711 (#824)
540fa5f
evankanderson added a commit that referenced this pull request Feb 20, 2019
@evankanderson
Fix env vars from #711 (#824)
86064bd
@evankanderson evankanderson deleted the indent-indent-indent branch March 7, 2019 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Harwayne Harwayne Harwayne left review comments

@scothis scothis Awaiting requested review from scothis

Assignees

@Harwayne Harwayne

@vaikas vaikas

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@evankanderson @vaikas @knative-prow-robot @Harwayne @googlebot @n3wscott