Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JobSink to support AuthZ on GET too #8196

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

creydr
Copy link
Member

@creydr creydr commented Sep 16, 2024

Proposed Changes

  • 🐛 Fix JobSink to support AuthZ on GET too
  • 🧹 Remove deprecated auth.VerifyJWTFromRequest() method.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 16, 2024
@knative-prow knative-prow bot requested a review from matzew September 16, 2024 15:52
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2024
Copy link

knative-prow bot commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 67.47%. Comparing base (608e76c) to head (1e1a860).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/jobsink/main.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8196      +/-   ##
==========================================
+ Coverage   67.45%   67.47%   +0.01%     
==========================================
  Files         371      371              
  Lines       18039    18036       -3     
==========================================
  Hits        12169    12169              
+ Misses       5091     5088       -3     
  Partials      779      779              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot merged commit ae6ed99 into knative:main Sep 16, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants