-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support authorization in Channel ingress #8162
Support authorization in Channel ingress #8162
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8162 +/- ##
==========================================
- Coverage 67.52% 67.47% -0.06%
==========================================
Files 371 371
Lines 17980 18001 +21
==========================================
+ Hits 12141 12146 +5
- Misses 5067 5084 +17
+ Partials 772 771 -1 ☔ View full report in Codecov by Sentry. |
Failing, because it's missing #8163 |
a35530a
to
7ce99b0
Compare
Rebased as #8163 merged |
@creydr should we add a unit test to the |
This can be hard, as the token verifier needs to run in the cluster and we don't have a mock for it :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, creydr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #7981
Follow up on #8123
Proposed Changes
Release Note