Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set UID in Brokers backing channels EventPolicies OwnerReference #8143

Merged

Conversation

creydr
Copy link
Member

@creydr creydr commented Aug 9, 2024

Currently seeing the following error in the controller logs:

failed to reconcile EventPolicy for Broker broker-iinpthqx: failed to create EventPolicy for Broker broker-iinpthqx-ep-broker-iinpthqx-kne-trigger: EventPolicy.eventing.knative.dev \"broker-iinpthqx-ep-broker-iinpthqx-kne-trigger\" is invalid: metadata.ownerReferences.uid: Invalid value: \"\": uid must not be empty

This PR addresses it and sets the UID in the Owner reference.

Proposed Changes

  • 🐛 Set UID in Brokers backing channels EventPolicies OwnerReference

@creydr creydr requested a review from rahulii August 9, 2024 06:55
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2024
@knative-prow knative-prow bot requested review from aliok and aslom August 9, 2024 06:55
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 9, 2024
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.89%. Comparing base (32f8491) to head (790e933).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8143      +/-   ##
==========================================
+ Coverage   67.88%   67.89%   +0.01%     
==========================================
  Files         368      368              
  Lines       17565    17571       +6     
==========================================
+ Hits        11924    11930       +6     
  Misses       4893     4893              
  Partials      748      748              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@creydr
Copy link
Member Author

creydr commented Aug 9, 2024

/cc @rahulii

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2024
@rahulii
Copy link
Contributor

rahulii commented Aug 9, 2024

/lgtm
/approve

Copy link

knative-prow bot commented Aug 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, rahulii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit ecb6c01 into knative:main Aug 9, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants