-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EventPolicy reconciliation for Parallel #8112
Add EventPolicy reconciliation for Parallel #8112
Conversation
Signed-off-by: rahulii <r.sawra@gmail.com>
Skipping CI for Draft Pull Request. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8112 +/- ##
==========================================
- Coverage 68.06% 67.80% -0.27%
==========================================
Files 369 370 +1
Lines 17726 17875 +149
==========================================
+ Hits 12066 12120 +54
- Misses 4901 4983 +82
- Partials 759 772 +13 ☔ View full report in Codecov by Sentry. |
Signed-off-by: rahulii <r.sawra@gmail.com>
Signed-off-by: rahulii <r.sawra@gmail.com>
Signed-off-by: rahulii <r.sawra@gmail.com>
Signed-off-by: rahulii <r.sawra@gmail.com>
Signed-off-by: rahulii <r.sawra@gmail.com>
Signed-off-by: rahulii <r.sawra@gmail.com>
Signed-off-by: rahulii <r.sawra@gmail.com>
Signed-off-by: rahulii <r.sawra@gmail.com>
And also from the failed reconciler test here, it seems like some of the changes break the existing Parallel OIDC tests. |
Signed-off-by: rahulii <r.sawra@gmail.com>
Signed-off-by: rahulii <r.sawra@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for working on this @rahulii. I left a few comments on this. Hope this helps, otherwise let us know.
Signed-off-by: rahulii <r.sawra@gmail.com>
Signed-off-by: rahulii <r.sawra@gmail.com>
I am taking a look at failed E2E tests ! |
/retest |
Signed-off-by: rahulii <r.sawra@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your work on this @rahulii and including all the reviews 👍
I only left a comment/question, but looks LGTM for me in general
Signed-off-by: rahulii <r.sawra@gmail.com>
/test reconciler-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks a lot for your work on this @rahulii
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, rahulii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #7984
Proposed Changes
Pre-review Checklist
Release Note
Docs